sign: switch to SHA2-256 signature by default #1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to SHA2-256 signature by default for the `melange sign` command. Use the same runtime opt-out back to SHA1 signatures as apko. With apko from: - chainguard-dev/apko#1440 This will use RSA256 signature type for both .apk & APKINDEX.tar.gz signing.
jonjohnsonjr
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to SHA2-256 signature by default for the
melange signcommand.
Use the same runtime opt-out back to SHA1 signatures as apko.
With apko from:
This will use RSA256 signature type for both .apk & APKINDEX.tar.gz
signing.