Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sca): Don't generate a dependnecy on ruby when found in shebang #1700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EyeCantCU
Copy link
Member

Every package that depends on cmd:ruby today, already depends on ruby-3.x

As cmd:ruby resolves to whatever has ruby and not necessarily the correct version of ruby, get rid of this as it is not needed and broken

SCA Changes

  • Examining several representative APKs show no regression / the desired effect (details in notes)

Notes: https://apk.chaindag.dev/https/packages.wolfi.dev/os/aarch64/APKINDEX.tar.gz@etag:b2b15507b98aca7d042d37e5612997e0/APKINDEX?full=false&search=&depend=cmd%3Aruby&provide=

Every package that depends on `cmd:ruby` today, already depends on
`ruby-3.x`

As `cmd:ruby` resolves to whatever has ruby and not necessarily the
correct version of ruby, get rid of this as it is not needed and broken

Signed-off-by: RJ Sampson <[email protected]>
@imjasonh imjasonh requested a review from smoser December 13, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant