feat: add support to add and drop linux capabilities #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxgio92
commented
Dec 13, 2024
| @@ -25,6 +25,7 @@ require ( | |||
| github.com/klauspost/compress v1.17.11 | |||
| github.com/klauspost/pgzip v1.2.6 | |||
| github.com/kubescape/go-git-url v0.0.30 | |||
| github.com/moby/moby v27.4.0+incompatible | |||
There was a problem hiding this comment.
This is the cost of tracking and aligning to Docker default capabilities.
maxgio92
commented
Dec 13, 2024
maxgio92
force-pushed
the
cap-add-drop
branch
4 times, most recently
from
449ec12 to
a19c214
Compare
This commit adds the configuration to add and drop Linux capabilies to the container for bubblewrap and docker runners, enabling a declarative way to do least privilege at both build and test time. Furthermore, the minimum set of process capabilities in Bubblewrap container is now the same of Docker default capabilities. Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
force-pushed
the
cap-add-drop
branch
from
a19c214 to
8e46080
Compare
maxgio92
changed the title
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
maxgio92
force-pushed
the
cap-add-drop
branch
from
d66f8b7 to
cbf421c
Compare
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
89luca89
approved these changes
Jan 8, 2025
philroche
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configuration to add and drop Linux capabilies to the container for bubblewrap and docker runners, enabling a declarative way to do least privilege. The capabilities added or dropped are relative to the minimum set of capabilities Docker sets. They are applied to all both build and test pipelines.
Furthermore, the minimum set of process capabilities in Bubblewrap container is now the same of Docker default capabilities, to improve result consistency.
Fixes #1703
Melange Pull Request Template
Functional Changes
Notes:
SCA Changes
Notes:
Linter
Notes: