Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accept newline-delimited packages and replaces #46

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jan 9, 2025

strings.Fields splits on any whitespace, including newlines

Example: https://go.dev/play/p/kp9y44Cg4aU

This enables something like:

- uses: go/bump
  with:
    packages: |
      foo.com/[email protected]
      bar.com/[email protected]

cmd/.DS_Store Outdated Show resolved Hide resolved
@hectorj2f
Copy link
Member

Nit: there is not packages: field is deps:

@hectorj2f
Copy link
Member

hectorj2f commented Jan 9, 2025

I'd like we add a test to validate the automation using it, as mentioned here https://chainguard-dev.slack.com/archives/C0636FTRFED/p1736446978629539?thread_ts=1736446317.594579&cid=C0636FTRFED, so we don't break anything that relies on deps: today

@debasishbsws
Copy link
Member

this will be great if the automation also start using this format.

Copy link
Member

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's try this syntax first on wolfi-bump.

@mamccorm
Copy link

mamccorm commented Jan 9, 2025

related: #2

Signed-off-by: Jason Hall <[email protected]>
@hectorj2f hectorj2f merged commit 6f9ee95 into chainguard-dev:main Jan 13, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants