introduce new --skip-initial-tidy flag
#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag would be useful for the cases where old packages contains old dependencies that would require to do _replace_ or _update_ before running `go mod tidy`. Signed-off-by: Dentrax <[email protected]>
|
Once we ship it, we should add a flag to the gobump pipeline in Wolfi. |
Thank you @hectorj2f, I have tried to add a unit test but I'm not sure if I did handle the case correctly. Please take a look when possible. |
Dentrax
force-pushed
the
skip-initial-tidy
branch
from
a2c16f9 to
55c69df
Compare
Signed-off-by: Dentrax <[email protected]>
Dentrax
force-pushed
the
skip-initial-tidy
branch
from
55c69df to
963fcae
Compare
|
CI is failing because of: |
Signed-off-by: Hector Fernandez <[email protected]> Signed-off-by: hectorj2f <[email protected]>
hectorj2f
force-pushed
the
skip-initial-tidy
branch
from
e211f82 to
aa1ef56
Compare
hectorj2f
approved these changes
Aug 6, 2024
|
Thanks for the fixing the CI issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag would be useful for the cases where old packages contains old dependencies that would require to do replace or update before running
go mod tidy.For example, for the following case:
https://github.com/iwilltry42/confd
It's impossible to use
gobumpsince one of dependencies got renamed, that required replace first:The new
--skip-initial-tidyflag solves that by skipping the firstgo mod tidyrun. So that we able to do required updates and replaces before rungo mod tidy.Do
git reset --hardand append the new--skip-initial-tidyflag, then expect to see a success output: