Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 fix: graphQL endpoint is not picking up data #105

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

Liquidwe
Copy link
Member

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

Fixes #97

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Enhancement, including but not limited to code refactoring, performance optimization, Test and CI
  • Dependency upgrade

@Liquidwe Liquidwe merged commit 1e3da90 into main Dec 17, 2024
@Liquidwe Liquidwe deleted the fix-graphql-track branch December 17, 2024 06:26
@KagemniKarimu
Copy link
Contributor

Please see #97 ❤️
State detection logic regressed in my tests. We may need to revert (or iterate on) these changes.

On a manuscript in an error state it shows:
image
Cluster state:
image

On a manuscript where jobmanager did not launch, it shows:
image
Cluster state:
image

On another occasion, it showed a manuscript whose endpoint was reachable, but data undetectable as RUNNING - whereas previously, it would have shown FAILED for both states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📈 GraphQL endpoint is not picking up data
2 participants