Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More ESM #68

Merged
merged 2 commits into from
Oct 19, 2023
Merged

More ESM #68

merged 2 commits into from
Oct 19, 2023

Conversation

koddsson
Copy link
Member

@koddsson koddsson commented Oct 19, 2023

Trying to push the ES module over the finish line.

  • I fully removed Karma in favor for Web Test Runner.
  • Removed the code coverage functionality. I didn't think it was used any more. I can add it back in if we'd like.

@koddsson koddsson force-pushed the more-esm branch 3 times, most recently from 72a31aa to d891866 Compare October 19, 2023 12:04
@koddsson koddsson marked this pull request as ready for review October 19, 2023 12:39
@koddsson
Copy link
Member Author

cc/ @keithamus

@keithamus keithamus merged commit 5fea3b1 into esm Oct 19, 2023
8 checks passed
@keithamus keithamus deleted the more-esm branch October 19, 2023 14:21
@keithamus
Copy link
Member

keithamus commented Oct 19, 2023

👍 nice work

keithamus added a commit that referenced this pull request Oct 20, 2023
* do not rely on resolution logic to import files

* drop FakeMap

* drop getFuncName, use .name instead

* import test deps as esm

* drop rollup

* port all code to typescript

* add deno mod.ts shortcut

* switch from .ts to .js extensions

* import lib rather than src in test/

Co-authored-by: 43081j <[email protected]>

* add web test runner config

Co-authored-by: 43081j <[email protected]>

* install wtr & friends

Co-authored-by: 43081j <[email protected]>

* fix test runner scripts

Co-authored-by: 43081j <[email protected]>

* More ESM (#68)

* fix: try getting esm working

* fix: update `esbuild`

* remove commitlint

---------

Co-authored-by: 43081j <[email protected]>
Co-authored-by: Kristján Oddsson <[email protected]>
Co-authored-by: Kristján Oddsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants