[Snyk] Fix for 2 vulnerabilities #2413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ELLIPTIC-8720086 - https://snyk.io/vuln/SNYK-JS-DOMPURIFY-8722251
This was referenced Feb 28, 2025
billhimmelsbach
added a commit
that referenced
this pull request
Mar 14, 2025
Based on dependabot vulnerabilities, we'll need to update two libraries: elliptic and jspdf. These are fairly minor updates, so we'll tackle them together. This will resolve the following PRs: #2318 #2317 #2413 and several dependabot alerts. 🚀 It's currently up on dev: `3.2.2f` 🚀 ## Changes - updates `elliptic` from `6.5.7` to `6.6.1` - updates `jspdf` from `2.5.1` to `2.5.2` - don't allow minor version updates to `jspdf` ## Testing - [x] Search to see if updates to the deps have been tried before, but were blocking changes for some reason in issues, PRs, etc - [x] Update package.json, run `yarn` to update the package.lock - [x] Run e2e tests locally - [x] Examine where these packages are used and ensure that these updates don't break anything not caught by e2e tests - [x] If everything looks good, proceed. Otherwise, revise code and chat with @ojbravo - [x] Deploy changes to Dev via CLI, run e2e tests again and test everything - [x] Get me admin access to this repo so I can make PRs, label and assign issues, etc. - [ ] Create a PR and merge in the security updates - [ ] Create a github release - [ ] Deploy mLAR changes to Prod via CLI (based on how I understand things currently are working with the caching workaround, these changes won't be visible until a manual deploy is done) - use the same image that's on dev - [ ] Test things out with the team, confirm e2e tests pass (wait till they run automatically or trigger manually) - [ ] 🥳 Closes #2418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
package.jsonyarn.lockNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-DOMPURIFY-8722251
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)