-
Notifications
You must be signed in to change notification settings - Fork 5
Upgrade to React v19 and Storybook v8 #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meissadia
wants to merge
8
commits into
main
Choose a base branch
from
392-upgrade-to-react19-and-storybook8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`npx storybook@latest migrate mdx-to-csf --glob "src/**/*.stories.mdx"`
- Remove incompatible addons - Migrate from @storybook/jest to @storybook/test - Remove deprecated configuration options
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jan 30, 2025
billhimmelsbach
added a commit
that referenced
this pull request
Apr 14, 2025
## Changes - updates storybook to v8 to fix a number of vite/rollup conflicts during security vulnerability resolution - separates out just the Storybook parts from this PR to limit fixes to only security vulnerabilities / avoid forcing metro2 to update react in order to get these updates: #396 ## How to test this PR 1. Does the site still load and does storybook appear to still work? Take a look at t[he deployed preview here](https://deploy-preview-400--cfpb-design-system-react.netlify.app/). ## Screenshots  Closes: [#339](#399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #393
Keep up-to-date with the latest major React release. For compatibility, also requires upgrading to Storybook v8.
Changes
npx react-codemod update-react-imports
npx codemod@latest react/19/migration-recipe
(no changes)npx types-react-codemod@latest preset-19 ./
import type { JSX } from 'react';
does address a TSC error, so those have been kept in placenpx storybook@latest migrate mdx-to-csf --glob "src/**/*.stories.mdx"
npx storybook@latest migrate csf-2-to-3 --glob="**/*.stories.tsx" --parser=tsx
npx storybook@latest upgrade
storyStoreV7
npx storybook migrate find-implicit-spies --glob="./src/**/*.stories.*"
(None found)argTypesRegex
yarn remove display-element-css
@storybook/jest
with@storybook/test
per guidanceHow to test this PR
yarn test
)sbl-frontend > yarn && yarn test:e2e:snapshot --headless
TODO
Potential blocker: Github actions failure -- Hanging process during
yarn test:ci
Jan 30 - This seems to be an intermittent error because, right now, the tests are passing without the hanging process 🤷🏾♂️
Note: this seems to be a pre-existing issue not caused by these upgrades
git checkout main && git pull && yarn && yarn test:ci
shows the same failureAttempted workarounds:
yarn run vitest --reporter=hanging-process
shows lots of the following, enough to overrun my terminal buffer, so I'm working to capture the full output for further evaluationvitest
does not fix ityarn run vitest run --pool=threads