Skip to content

wip fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue, TextInput changes, Checkbox changes #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wip fix: [AlertFieldLevel] margin 0.5em, icon vertical centering issue, TextInput changes, Checkbox changes #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/components/Alert/Alert.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@
position: absolute;
}

.m-notification:not(.m-notification__error, .m-notification__success, .m-notification__warning) .cf-icon-svg {
.m-notification:not(.m-notification__error, .m-notification__success, .m-notification__warning)
.cf-icon-svg {
fill: #5a5d61;
}

.cf-icon-svg-wrapper+.m-notification_content {
.cf-icon-svg-wrapper + .m-notification_content {
padding-left: 1.5625em;
}

Expand All @@ -20,4 +21,14 @@

.m-notification .m-list .cf-icon-svg-wrapper .cf-icon-svg {
fill: currentcolor;
}
}

.a-alertfieldlevel-text {
display: inline;
margin-left: 0.5em;
}

.a-alertfieldlevel-container {
display: flex;
align-items: center;
}
8 changes: 6 additions & 2 deletions src/components/Alert/AlertFieldLevel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { JSXElement } from '~/src/types/jsxElement';
import { Icon } from '../Icon/Icon';
import './Alert.css';

export type AlertFieldLevelType = 'error' | 'info' | 'success' | 'warning';

Expand Down Expand Up @@ -41,12 +42,15 @@ export const AlertFieldLevel = ({

return (
<div
className={`a-form-alert a-form-alert${AlertFieldLevelClass[status]}`}
className={`a-form-alert a-form-alert${AlertFieldLevelClass[status]} a-alertfieldlevel-container`}
role='alert'
{...properties}
>
<Icon name={MapTypeToIconName[status]} alt={status} withBg />
<span className='a-form-alert_text' data-testid='message'>
<span
className='a-form-alert_text a-alertfieldlevel-text'
data-testid='message'
>
{message}
</span>
</div>
Expand Down