Skip to content

feat: Initial text + icon table #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: Initial text + icon table #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f079d10
feat: Initial text + icon table
meissadia Aug 8, 2023
b3225ad
fix: Apply 1   worth of margin between icon/text
meissadia Aug 8, 2023
624c1b6
fix: Focus on known use cases
meissadia Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/components/Icon/Icon.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Calculation methodology
// https://github.com/cfpb/design-stories/issues/130#issuecomment-1670396537
@width-of-1-nbsp: 0.3098125em;

.u-icon-before-text .cf-icon-svg-wrapper {
margin-right: @width-of-1-nbsp;
}

.u-icon-after-text .cf-icon-svg-wrapper {
margin-left: @width-of-1-nbsp;
}

.t-icon-with-text {
width: 100%;
}
50 changes: 50 additions & 0 deletions src/components/Icon/Icon.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,56 @@ export const IconWithBackground = (): React.ReactElement => (
</span>
);

export const IconWithText = (): React.ReactElement => {
const elements = ['h1', 'h2', 'h3', 'h4', 'h5', 'p', 'a'];

return (
<table className='t-icon-with-text'>
<thead>
<tr>
<th>Element</th>
<th>Text + Icon</th>
<th>Icon + Text</th>
<th>Round Icon + Text</th>
</tr>
</thead>
<tbody>
{elements.map(element => {
const DynamicTag = element;

return (
<tr key={element}>
<td>{element}</td>
<td>
<DynamicTag className='u-icon-after-text'>
{element} text
<Icon name='email' />
</DynamicTag>
</td>

<td>
<DynamicTag className='u-icon-before-text'>
<Icon name='email' />
{element} text
</DynamicTag>
</td>
<td>
<DynamicTag className='u-icon-before-text'>
<Icon name='zero' withBg />
{element} text
</DynamicTag>
</td>
</tr>
);
})}
<tr>
<td>test space</td>
</tr>
</tbody>
</table>
);
};

export const NavigationIcons = (): React.ReactElement => (
<IconTable>{makeRows(navigationIcons)}</IconTable>
);
Expand Down
2 changes: 2 additions & 0 deletions src/components/Icon/Icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import classNames from 'classnames';
import { useIconSvg } from '../../hooks/useIconSvg';
import { numberIcons } from './iconLists';

import './Icon.less';

// Design System font sizes for HTML elements
const sizeMap: Record<string, string> = {
h1: '34px',
Expand Down