Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add querystring param to cache-bust pages URL #48

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

chosak
Copy link
Member

@chosak chosak commented Dec 12, 2024

The nightly Lighthouse run pulls down a list of URLs to test from a URL that is configured via a GitHub Secret. This secret value currently points to a GitHub gist raw URL, e.g.

https://gist.githubusercontent.com/username/abcdef123456/raw/

Unfortunately, this URL doesn't always return the latest version of the gist, apparently due to some caching on GitHub's side. To try to bypass this caching, we can try to add a random querystring to the URLs being fetched, e.g. ?12345678.

The nightly Lighthouse run pulls down a list of URLs to test from a
URL that is configured via a GitHub Secret. This secret value currently
points to a GitHub gist raw URL, e.g.

https://gist.githubusercontent.com/username/abcdef123456/raw/

Unfortunately, this URL doesn't always return the latest version of the
gist, apparently due to some caching on GitHub's side. To try to
bypass this caching, we can try to add a random querystring to the URLs
being fetched, e.g. ?12345678.
@chosak chosak merged commit 291a1c3 into main Dec 12, 2024
1 check passed
@chosak chosak deleted the fix/cache-bust-pages-url branch December 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants