Conversation
In the most recent versions of Lighthouse, the configuration settings we were using for desktop testing no longer work. Instead of using formFactor and screenEmulation, we should use the "desktop" preset. This commit makes that change which properly tests using a desktop form factor; this can be confirmed by looking at the (small) screenshots included as part of a Lighthouse report. With this change, our desktop Performance scores now are in the 90s, which is more consistent with how things work when you run from Chrome developer tools.
| settings: { | ||
| formFactor: mobile ? 'mobile' : 'desktop', | ||
| screenEmulation: { mobile: mobile }, | ||
| maxWaitForLoad: 5000 |
Member
There was a problem hiding this comment.
Are we in danger of running into #30 with this line gone?
Member
Author
There was a problem hiding this comment.
I thought it was worth giving this simplification a shot, since we're now on a more recent release of Lighthouse.
anselmbradford
approved these changes
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the most recent versions of Lighthouse, the configuration settings we were using for desktop testing no longer work. Instead of using
formFactorandscreenEmulation, we should use the"desktop"preset.This commit makes that change which properly tests using a desktop form factor; this can be confirmed by looking at the (small) screenshots included as part of a Lighthouse report.
With this change, our desktop Performance scores now are in the 90s, which is more consistent with how things work when you run from Chrome developer tools.