Skip to content

ENT-13591: Fixed buffer overflow in cf-secret when using multiple keys of different sizes #5992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larsewi wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

ENT-13591: Fixed buffer overflow in cf-secret when using multiple keys of different sizes #5992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cf-secret/cf-secret.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,13 +343,13 @@ static bool RSAEncrypt(Seq *rsa_keys, const char *input_path, const char *output

const EVP_CIPHER *cipher = EVP_aes_256_cbc();
EVP_CIPHER_CTX *ctx = EVP_CIPHER_CTX_new();
const int key_size = EVP_PKEY_size((EVP_PKEY*) SeqAt(evp_keys, 0));

/* This sequence and the 'enc_key_sizes' array are both populated by the
* EVP_SealInit() call below. */
Seq *enc_keys = SeqNew(n_keys, free);
for (size_t i = 0; i < n_keys; i++)
{
const int key_size = EVP_PKEY_size((EVP_PKEY*) SeqAt(evp_keys, i));
SeqAppend(enc_keys, xmalloc(key_size));
}
int enc_key_sizes[n_keys];
Expand Down
Loading