ENT-13540: time_based_vars.cf: refactored acceptance test #5987
+72
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsewi
force-pushed
the
time-based-vars
branch
from
80d5ded to
7353284
Compare
craigcomstock
approved these changes
Dec 9, 2025
Contributor
craigcomstock
left a comment
craigcomstock
left a comment
There was a problem hiding this comment.
so lovely. thank you. :)
larsewi
force-pushed
the
time-based-vars
branch
3 times, most recently
from
0609e16 to
12ba2da
Compare
Refactored test to print debug information when test fails. This will hopefully reveal why the test fails every now and then. Ticket: ENT-13540 Signed-off-by: Lars Erik Wik <[email protected]>
It assumed that it would contain the 24th hour instead of the 0th. Now both are accepted. It also appears the regex for `hr` and `hr_2` was mixed up. ``` R: FAIL: "default:sys.time_based_gmt_hr => GMT_Hr00" did not match "^GMT_Hr([1-9]|1[0-9]|2[0-4])$" R: FAIL: "default:sys.time_based_gmt_hr_2 => GMT_Hr0" did not match "^GMT_Hr(0[1-9]|1[0-9]|2[0-4])$" R: FAIL: "default:sys.time_based_gmt_hr_qoh => GMT_Hr00_Q1" did not match "^GMT_Hr(0[1-9]|1[0-9]|2[0-4])_Q[1-4]$" ``` Ticket: ENT-13540 Signed-off-by: Lars Erik Wik <[email protected]>
larsewi
force-pushed
the
time-based-vars
branch
from
12ba2da to
2fed7eb
Compare
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored test to print debug information when test fails. This revealed why the test fails every now and then.
It assumed that it would contain the 24th hour instead of the 0th. Now both are accepted. It also appears the regex for
hrandhr_2was mixed up.Ticket: ENT-13540
Signed-off-by: Lars Erik Wik [email protected]