-
Notifications
You must be signed in to change notification settings - Fork 49
WIP: added text allowing "Z" for timezone offset. #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1773779
added text allowing "Z" for timezone offset, and recommending that ze…
ChrisBarker-NOAA 4def5e0
updated to have better phrasing and weaken the suggesting to specify …
ChrisBarker-NOAA b82ff3a
fixed typo
ChrisBarker-NOAA 0aa9a3a
included suggestions from Issue #584
ChrisBarker-NOAA 3081cff
adding a "Z" timezone offsets to a couple examples.
ChrisBarker-NOAA 1b01c60
copy-editing, responding to PR comments
ChrisBarker-NOAA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,7 @@ dimensions: | |
variables: | ||
float time(time); | ||
time:standard_name = "time"; | ||
time:units = "days since 2024-11-8 09:00:00"; | ||
time:units = "days since 2024-11-8 09:00:00 Z"; | ||
ChrisBarker-NOAA marked this conversation as resolved.
Show resolved
Hide resolved
|
||
time:bounds = "time_bnds"; | ||
float time_bnds(time,nv); | ||
---- | ||
|
@@ -330,7 +330,7 @@ variables: | |
ppn:cell_methods = "time: sum"; | ||
double time(time); | ||
time:long_name = "time"; | ||
time:units = "h since 1998-4-19 6:0:0"; | ||
time:units = "h since 1998-4-19 6:0:0 Z"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Edit - just seen the above conversion on this, so I retract the comment!
|
||
time:bounds = "time_bnds"; | ||
double time_bnds(time,nv); | ||
data: | ||
|
@@ -400,7 +400,7 @@ variables: | |
TS_var:units="K2"; | ||
TS_var:cell_methods="time: variance (interval: 1 hr comment: sampled instantaneously)"; | ||
float time(time); | ||
time:units="days since 1990-01-01 00:00:00"; | ||
time:units="days since 1990-01-01 00:00:00 Z"; | ||
time:bounds="time_bnds"; | ||
float time_bnds(time,nv); | ||
data: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.