Added Shodan Alert API Collector #2618
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebix
added
feature
|
test will succeed with #2619 |
In cooperation with Malawi CERT
kamil-certat
requested changes
Jun 26, 2025
| raise ValueError("Library 'shodan' is needed but not installed.") | ||
|
|
||
| self.set_request_parameters() | ||
| if tuple(int(v) for v in pkg_resources.get_distribution("shodan").version.split('.')) <= (1, 8, 1): |
There was a problem hiding this comment.
- Looks like
pkg_resourcesis not imported - It's deprecated anyway, and will be gone soon, please use replacements
There was a problem hiding this comment.
- Let's add this check to
checkmethod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created in cooperation with Malawi CERT