Fixed behaviour if parameter types value is empty string, behave th…
#2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same way as not set, not like no type.
elsif2
force-pushed
the
shadowserver-intelmq-manager-types
branch
from
a84a73b to
06b395b
Compare
sebix
approved these changes
Nov 21, 2024
| @@ -19,6 +19,8 @@ | |||
|
|
|||
| ### Bots | |||
| #### Collectors | |||
| - `intelmq.bots.collectors.shadowserver.collector_reports_api.py`: | |||
| - Fixed behaviour if parameter `types` value is empty string, behave the same way as not set, not like no type. | |||
There was a problem hiding this comment.
Suggested change
| - Fixed behaviour if parameter `types` value is empty string, behave the same way as not set, not like no type. | |
| - Fixed behaviour if parameter `types` value is empty string, behave the same way as not set, not like no type (PR#2536 by Jason). |
|
Thanks for the fix. Unfortunately, the actual problem is much bigger than that of single parameters and requires a generic solution. Multiple users are falling into this trap regularly and it hurts the usability of IntelMQ massively. |
sebix
added
bug
kamil-certat
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of the types list being empty when the runtime config is generated with the web manager:
A similar fix was made for reports previously.