Fix maintaining pipeline when using AMQP #2533
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If RabbitMQ droped the connection, pika can emit the StreamLostError which can be gracefully handled by reconnection attempt. In addition, consuming on BlockingConnection without the timeout can block internal maintanence operations, like sending heartbeats [1]. [1] https://pika.readthedocs.io/en/1.2.0/modules/adapters/blocking.html#pika.adapters.blocking_connection.BlockingChannel.consume
kamil-certat
force-pushed
the
amgp_timeout
branch
from
dba7533 to
d10439d
Compare
sebix
added
bug
sebix
requested changes
Nov 4, 2024
Comment on lines
+611
to
+614
| if reconnect and ( | ||
| isinstance(exc, pika.exceptions.ConnectionClosed) or | ||
| isinstance(exc, pika.exceptions.StreamLostError) | ||
| ): |
There was a problem hiding this comment.
Suggested change
| if reconnect and ( | |
| isinstance(exc, pika.exceptions.ConnectionClosed) or | |
| isinstance(exc, pika.exceptions.StreamLostError) | |
| ): | |
| if reconnect and isinstance(exc, (pika.exceptions.ConnectionClosed, pika.exceptions.StreamLostError)): |
Comment on lines
+654
to
+656
| method, _, body = next( | ||
| self.channel.consume(self.source_queue, inactivity_timeout=self.heartbeat / 2) | ||
| ) |
There was a problem hiding this comment.
Can you please add an inline comment on why there's a need for a loop and why you chose heartbeat/2? That will make our lives easier when reading the code later on.
| @@ -12,6 +12,7 @@ | |||
| ### Configuration | |||
|
|
|||
| ### Core | |||
| - Fix maintaining pipeline connection when using AMQP (PR# by Kamil Mankowski). | |||
There was a problem hiding this comment.
Suggested change
| - Fix maintaining pipeline connection when using AMQP (PR# by Kamil Mankowski). | |
| - AMQP: Fix maintaining pipeline connection when during interrupted connections (PR#2533 by Kamil Mankowski). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If RabbitMQ dropped the connection, pika can emit the StreamLostError which can be gracefully handled by reconnection attempt. In addition, consuming on BlockingConnection without the timeout can block internal maintenance operations, like sending heartbeats [1].
[1] https://pika.readthedocs.io/en/1.2.0/modules/adapters/blocking.html#pika.adapters.blocking_connection.BlockingChannel.consume