use PyMISP, ExpandedPyMISP is deprecated #2532
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late reaction; I missed the PR. What is the minimum required pymisp version now? Are the @Rafiot (author of both bots) can you please check if that's correct? |
|
I'd suggest to bump the requirements to the most recent release (they have wheels, and are for sure supporting python 3.9 to 3.13) but it's not required as the API hasn't changed. Regarding the changes PyMISPExpanded -> PyMISP, yes, it is correct. |
Thank you! |
sebix
added a commit
to rvyhnal/intelmq
that referenced
this pull request
Dec 8, 2024
sebix
added a commit
to rvyhnal/intelmq
that referenced
this pull request
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MISP related bots try to import the deprecated ExpandedPyMISP instead of PyMISP which produces the deprecation message in logs.
As ExpandedPyMISP was introduced for the transition to Python3 quite some time ago, please consider merging this PR.