Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PyMISP, ExpandedPyMISP is deprecated #2532

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

rvyhnal
Copy link

@rvyhnal rvyhnal commented Oct 18, 2024

MISP related bots try to import the deprecated ExpandedPyMISP instead of PyMISP which produces the deprecation message in logs.
As ExpandedPyMISP was introduced for the transition to Python3 quite some time ago, please consider merging this PR.

@sebix
Copy link
Member

sebix commented Nov 29, 2024

Sorry for the late reaction; I missed the PR.

What is the minimum required pymisp version now? Are the REQUIREMENTS.txt in both files' directories still correct?

@Rafiot (author of both bots) can you please check if that's correct?

@Rafiot Rafiot self-assigned this Nov 29, 2024
@Rafiot
Copy link
Member

Rafiot commented Dec 2, 2024

I'd suggest to bump the requirements to the most recent release (they have wheels, and are for sure supporting python 3.9 to 3.13) but it's not required as the API hasn't changed.

Regarding the changes PyMISPExpanded -> PyMISP, yes, it is correct.

@sebix
Copy link
Member

sebix commented Dec 2, 2024

Regarding the changes PyMISPExpanded -> PyMISP, yes, it is correct.

Thank you!

@sebix sebix self-assigned this Dec 2, 2024
@sebix sebix added this to the 3.3.2 Bugfix release milestone Dec 2, 2024
@sebix sebix unassigned Rafiot Dec 2, 2024
sebix added a commit to rvyhnal/intelmq that referenced this pull request Dec 8, 2024
sebix added a commit to rvyhnal/intelmq that referenced this pull request Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants