DOC: Changes documentation to mkdocs #2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gethvi
changed the title
gethvi
force-pushed
the
mkdocs
branch
14 times, most recently
from
d5f51da to
cb0df01
Compare
sebix
requested changes
Nov 2, 2023
gethvi
force-pushed
the
mkdocs
branch
4 times, most recently
from
4bfc672 to
f3cdab6
Compare
kamil-certat
reviewed
Nov 6, 2023
There was a problem hiding this comment.
I haven't checked all changes in the docs (this will come with the usage, but I feel you also addressed some my concerns about the docs structure :D). I love the change, and want to see it online <3
However, could you please bring back to the README two things:
- IntelMQ logo (because it looks sad on GitHub without it)
- European funding info (because I'm pretty sure there are still active legal requirements to say it clearly).
I'd also add a link to docs in the README - even if it would be redundant on the docs website, it's important in GitHub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live version: https://gethvi.github.io/intelmq/mkdocs/