fix: https://cert-manager.io/v1.12-docs doesn't work #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
|
The preview build failure looks legitimate! |
jetstack-bot
added
size/XL
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I forgot to change the manifest.json when releasing v1.12. The command is: sed -i.bak 's|/docs/|/v1.12-docs/|g' content/v1.12-docs/manifest.json I also edited the release process document to reflect that in another PR. Signed-off-by: Maël Valais <[email protected]>
I updated the release process to mention this. Command I ran is:
jq 'del(.. | select(.path? | select(.) | test(".*(installation/supported-releases.md|installation/upgrading|release-notes).*")))' \
content/v1.12-docs/manifest.json >tmp && mv tmp content/v1.12-docs/manifest.json
Signed-off-by: Maël Valais <[email protected]>
maelvls
force-pushed
the
fix-1.12-docs-missing
branch
from
24ecb38
to
f2e7ee9
Compare
jetstack-bot
added
size/L
SgtCoDFish
requested changes
Jun 21, 2023
|
Relates to #1243 |
Command used:
cat content/v1.12-docs/manifest.json \
| jq 'del(.. | select(.path? | select(.) | test(".*(installation/supported-releases.md|installation/upgrading|release-notes).*")))' \
| jq 'del(.. | select(.routes? == []))' >/tmp/manifest \
&& mv /tmp/manifest content/v1.12-docs/manifest.json
Signed-off-by: Maël Valais <[email protected]>
maelvls
force-pushed
the
fix-1.12-docs-missing
branch
from
c496aa4
to
932e47b
Compare
SgtCoDFish
approved these changes
Jun 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to change the manifest.json when releasing v1.12. The command is:
I also edited the release process document to reflect that in #1229.