-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMS Getting Started for AOD, MiniAOD, NanoAOD #3551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not wrong the standard mkedanlz does not produce code that works in CMSSW_10_6_30. It is not the container feature but the release feature: it includes objects that are not in the standard miniaod (and also does not produce the config file). A mention of that could be added. A work-through attempt is reported in the GitLab issue in https://gitlab.cern.ch/cms-cloud/cmssw-docker-opendata/-/issues/18#note_7141873)
The current MiniAOD mkedanlz instructions work in 7_6_7 container, so that correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! After a quick reading, the only point I have is to add a mention that the 2016 MiniAOD mkedanlz does not work as such.
Ok, @katilp do we not have the same "hack" in that container that we do in 767? If not, it would be useful to add it in the upcoming refreshes... ETA: plan is to recheck all the commands today in 10-6h30, there was some issues with finding enough disk space for the container... |
This a different problem, it is not just to make it work: it works but provides a non-working example |
Ah, ok I remember now -- will check tonight and make a working EDAnalyzer
in a repo
And of course try to make the checks pass
…On Wed, Jan 31, 2024, 10:15 AM Kati Lassila-Perini ***@***.***> wrote:
Ok, @katilp <https://github.com/katilp> do we not have the same "hack" in
that container that we do in 767? If not, it would be useful to add it in
the upcoming refreshes...
This a different problem, it is not just to make it work: it works but
provides a non-working example
So some heavier hacking would be needed. I'd go for a git repository with
a basic equivalent skeleton
—
Reply to this email directly, view it on GitHub
<#3551 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACVFOJCUPG3X26S5DBFLBF3YRJUY7AVCNFSM6AAAAABCSMV57KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJZGQZTKNJWGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@katilp new commits change up the EDAnalyzer example in MiniAOD:
I also (for now) have removed the note that cmsenv should not be done in the container. I need to triple check the rendering tomorrow on my desktop where I've worked up until now. I'm getting HTTPS Connection refused messages on my laptop when I run any of the instance cleaning or populating commands, though build, up, and down commands are successful. To be seen whether I can pass the checks... |
Ok, ready to go on my side. |
Perfect, thanks! |
Thanks @tiborsimko that sounds good -- it's too bad that the Github Preview is so helpful for markdown editing compared to rendering the site, very tempting to just hit that "commit" button. We discussed how to avoid so many commits in the future. |
Thanks, I'll write over your PR then with everything squashed. BTW no problem in having many small commits whilst developing! It can be very useful. We are simply cleaning branches before merging as the last step, just to get rid of some intermediate commits when they aren't fully necessary to preserve. This facilitates future updates or bug fix hunting. (See also the developing guide.) |
This PR adds docs pages for CMS AOD, MiniAOD, and NanoAOD formats, addressing several tasks in cernopendata#3452. Some of the contents of these pages refer to records that will be made in the future. Hopefully all links are currently valid, but several should updated with new records before new CMS documentation are records are put into production. (cernopendata#3495, cernopendata#3496, cernopendata#3537, cernopendata#3281, cernopendata#3279) This slightly addresses cernopendata#3465 by no longer linking to these older records as examples. Co-authored-by: Xiaohe Shen <[email protected]>
8655876
to
1556a90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, squashed as discussed, renamed the location of supporting images, added you and Xiaohe as co-authors.
This PR adds docs pages for CMS AOD, MiniAOD, and NanoAOD formats, addressing several tasks in #3452.
Please forgive the inevitable first-time-contributor gaffs!
Some of the contents of these pages refer to records that will be made in the future. Hopefully all links are currently valid, but several should updated with new records before new CMS documentation are records are put into production. (#3495, #3496, #3537, #3281, #3279)
This slightly addresses #3465 by no longer linking to these older records as examples.