[terra-icon] accessibility upgrade #3598
Conversation
|
Trying to do VoiceOver testing on the meaningful/decorative icon test. How have you been checking icons with screen readers? I can't get VoiceOver to focus on the icons no matter what I do. |
|
@jeremyfuksa I did |
| @@ -1,10 +1,20 @@ | |||
| # Update all SVG icons | |||
There was a problem hiding this comment.
A command could be added for each heading in this file with more than one command under it: update-all-svg-icons, generate-meaningful-icons, generate-decorative-icons
There was a problem hiding this comment.
Updated scripts here: 6e36b79
There was a problem hiding this comment.
Dove a little deeper into this:
npm run migrate-cerner-one-iconswon't work now becausenpm generate-iconisn't a script.- If
npm run generate-all-iconsis supposed to be part ofnpm run migrate-cerner-one-icons, wouldn't all steps in this document be completed in step 1?
- If
- Under the "Step 2 - Generate meaningful icons" heading:
npm run generate-iconisn't a thing now.- Once it's changed to reflect the new name for the command, everything but the last command is done directly by the command in step 1.
npm run replace-decorative-importis part of thegenerate-decorative-iconscommand but isn't in the list of commands in this file to generate decorative icons
There was a problem hiding this comment.
Oh try pulling. I updated the readme and scripts.
Co-authored-by: Eric Wilson <[email protected]>
|
(My +1 does not constitute a UX review, by the way. That's still @jeremyfuksa ) |
There was a problem hiding this comment.
Tested: PR #3598
Resolves: Issue #3123
Reviewed:
- Follows accessibility standards as determined by UX Foundations.
Verified by @jeremyfuksa, Marking as Verified, Ready for Release.
| Pass |
|---|
| UX Review |
Summary
A major upgrade for terra-icon to meet accessibility guidelines.
Closes #3123
Deployment Link
https://terra-core-deployed-pr-#.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra