Bz2242346 prometheus port #7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a custom Prometheus port was used before adoption, it was not taken into account and default 9095 was set instead. Now custom port is re-applied. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2242346 Signed-off-by: Teoman ONAY <[email protected]>
|
jenkins test centos-container-all_daemons |
asm0deuz
force-pushed
the
BZ2242346_prometheus_port
branch
from
292d13c
to
50f147e
Compare
Regression from ceph#7576. Alertmanager placement count was missing after migration to ceph_orch_apply module Signed-off-by: Teoman ONAY <[email protected]>
asm0deuz
force-pushed
the
BZ2242346_prometheus_port
branch
from
50f147e
to
0385fd0
Compare
guits
approved these changes
Oct 14, 2024
This was referenced Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cephadm_adopt does not keep Prometheus custom port during adoption
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2242346