Dashboard: replace hardcoded groupname with groupname variable #7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach is extremely complex and introduced a lot of spaghetti code. This doesn't offer a good user experience at all. It's time to think to another approach (dedicated playbook) and drop the current implementation in order to clean up the code. Signed-off-by: Guillaume Abrioux <[email protected]>
This addresses all errors reported by the Ansible linter. Signed-off-by: Guillaume Abrioux <[email protected]>
This service is no longer maintained. Let's drop its support within ceph-ansible. Signed-off-by: Guillaume Abrioux <[email protected]>
RHCS moved away from ceph-ansible. All RHCS references should be removed. Signed-off-by: Guillaume Abrioux <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
This is needed for new instances are the restart might trigger before the deployment Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
* Make common params of container args in a var to avoid duplication * The /var/lib/ceph/crash mount was missing after 637ca81 * Add CEPH_USE_RANDOM_NONCE as it's needed when running inside container (can be removed for squid later) * Add NODE_NAME as some part of ceph code relies on this var * add default logging opts for Signed-off-by: Seena Fallah <[email protected]>
Diff option can help in CI when a task fail because of a corrupted render in previous tasks. Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
This can help to define custom rgw_instances with custom names and ports and addresses. Signed-off-by: Seena Fallah <[email protected]>
regression by dcdb171 Signed-off-by: Seena Fallah <[email protected]>
If mgr is meant to be installed on the mon host it needs to be installed in the same playbook as restart handlers might failed because of non-existance mgr Signed-off-by: Seena Fallah <[email protected]>
This can help to have extra params or modify the existing ones via group vars. Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
stable-8.0 is not ready and shouldn't be used for now. Signed-off-by: Guillaume Abrioux <[email protected]>
this addresses 3 linter errors in rolling update playbook Signed-off-by: Guillaume Abrioux <[email protected]>
Signed-off-by: Guillaume Abrioux <[email protected]>
this drops the following parameters: - monitor_address_block - monitor_interface - monitor_address The monitor address will be automatically set from `public_network` parameter. Signed-off-by: Guillaume Abrioux <[email protected]>
2b72ea9 and c8eeae2 have missed the resync. This addresses that. Signed-off-by: Guillaume Abrioux <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>
this job was removed, these files are no longer needed, let's remove them. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit 05a1465)
All of this should be addressed in custom separate playbooks if needed. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit 9c467e4)
stable-8.0 is reef so this must check the right value for ceph_stable_release Signed-off-by: Guillaume Abrioux <[email protected]>
Signed-off-by: Guillaume Abrioux <[email protected]>
Signed-off-by: Guillaume Abrioux <[email protected]>
If rgw is configured to only operate admin api - this is the status code it will return for GET on no path. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 9f9b32e)
ceph-volume has a dependency on `python3-packaging` which is available in PowerTools repo. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit 8ebff21)
Although custom cluster name support was dropped, it breaks ceph-volume functional testing as it uses "test" as cluster name. The plan is to make ceph-volume use "ceph" but for now it's easier to address the issue in this task. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit c4b3520)
Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 326e2e4)
Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit fb13ee3)
so you don't have to implement a similar play on your own if not using main (sample) playbooks. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit ba7eb62)
ba7eb62 broke deployments where mgrs are not collocated with mons. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit 4f6641f)
Set return code to 0 on check mode when the user doesn't exists and it will fail the module. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 878cce5)
Fixes cephadm-adopt test scenario by configuring rbd application on test and test2 pools. Otherwise cephadm-adopt failed at task "Check pools have an application enabled" Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit ca191fa)
This is needed by ceph-exporter as it is parsing the socket by the number of dots. Although the rgw_zone variable is only using for constructing the client name and has nothing to do with multisiting. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 1121e6d)
Make it the same as "Create ceph initial directories" task and make owner and group 167 for containers so they can write with ceph user. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 65c84a3)
Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 779a13e)
Use --setuser and --setgroup to ceph to run daemons with ceph user. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 7016c6d)
check if the key is exists before removal. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 5236516)
Add new module ceph_orch_spec which applies ceph spec files. This feature was needed to bind extra mount points to the RGW container (/etc/pki/ca-trust/). Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2262133 Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit f6fd034)
As is idempotency does not work as the ceph orch output does contain more attributes than the expected spec. Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 5a44fbe)
This reverts commit 675667e. Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit 59198f5)
RGW currently restarts without waiting for existing connections to close. By adjusting the HAProxy weight before the restart, we can ensure that no active connections are disrupted during the restart process. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit 4fa9057)
In test scenarios Signed-off-by: Teoman ONAY <[email protected]>
spec file template conditions were incorrect Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit e85060c)
Signed-off-by: Teoman ONAY <[email protected]>
Alertmanager was bind to default * network instead of grafana_server_addr as it was before. Now on if grafana_server_addr is defined, it will be bind to that network. Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 0bf3398)
networks was at the wrong level in the spec file. Failed with "got an unexpected keyword argument 'networks'" Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 2c88ecc)
In some scenarios with NVMe, a device might be identified by Ansible but could actually be a multipath device rather than an actual device. We need to exclude these as Ceph cannot create OSDs on them. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit be9b458)
Support updating crush rule of the pool via crush rule name. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit d6ac0cc)
Supporting adding/removing caps on the user. Signed-off-by: Seena Fallah <[email protected]> (cherry picked from commit c1f1c1e)
ceph orch ls rgw --format=yaml returns multiple documents when multiple rgw are installed, this was not handled correctly. Signed-off-by: Teoman ONAY <[email protected]> (cherry picked from commit 823700b)
Add task to set customized ssh config for cephadm Signed-off-by: Amir Nikpour <[email protected]> (cherry picked from commit e4ab45d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little PR for replacing hard-coded group names with the group name variables defined.
Without this modification, we can't deploy dashboard with our global dynamic inventory.