Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctor-1322 enh(add new test mode)network::fortinet::fortigate::snmp, Mode(sdwan) #5421

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Ctor-1322 enh(add new test mode)network::fortinet::fortigate::snmp, Mode(sdwan) #5421

merged 6 commits into from
Feb 5, 2025

Conversation

sfarouq-ext
Copy link
Contributor

@sfarouq-ext sfarouq-ext commented Feb 4, 2025 •
edited by lucie-dubrunfaut
Loading

CTOR-1322
CTOR-1239

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • I have provide data or shown output displaying the result of this code in the plugin area concerned.

jummo and others added 5 commits February 4, 2025 09:43
@jummo @sfarouq-ext
Update sdwan.pm - Fix incorrect traffic counters calculation
13f54e6 
The traffic counters are reported via SNMP are in kbps and only needs to be multiple by 1000 to get the bps values.
@sfarouq-ext
WIP
71af51e
@sfarouq-ext
WIP
25569aa
@sfarouq-ext
WIP
859ebd1
@sfarouq-ext
adding snmpwalk
c2e78de
@sfarouq-ext sfarouq-ext requested review from a team as code owners February 4, 2025 09:10
@Evan-Adam Evan-Adam merged commit ee48767 into develop Feb 5, 2025
30 checks passed
@Evan-Adam Evan-Adam deleted the CTOR-1322-plugin-network-fortinet-fort branch February 5, 2025 10:43
@lucie-dubrunfaut lucie-dubrunfaut mentioned this pull request Feb 7, 2025
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evan-Adam Evan-Adam Evan-Adam approved these changes

@bouda1 bouda1 Awaiting requested review from bouda1 bouda1 is a code owner automatically assigned from centreon/owners-robot-e2e

@jean-christophe81 jean-christophe81 Awaiting requested review from jean-christophe81 jean-christophe81 is a code owner automatically assigned from centreon/owners-robot-e2e

@omercier omercier Awaiting requested review from omercier omercier is a code owner automatically assigned from centreon/owners-perl

Assignees
No one assigned
Labels
skip-workflow-plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfarouq-ext @Evan-Adam @jummo