Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTOR-644-plugin-network-moxa-switch-snmp-mode-interfaces-option-add-duplex-status-duplex-unknown #5420

Conversation

Evan-Adam
Copy link
Contributor

Refs:CTOR-644

Description

fix --add-duplex-status for moxa switch to use the private mib.
See

Fixes ##4822

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

See automated test, run the plugin against the moxa switch with --add-duplex-status option

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
    • Data used for automated tests are anonymized.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences end with a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@Evan-Adam Evan-Adam force-pushed the CTOR-644-plugin-network-moxa-switch-snmp-mode-interfaces-option-add-duplex-status-duplex-unknown branch 2 times, most recently from 0c5a5e1 to a97ec71 Compare February 4, 2025 10:47
@Evan-Adam Evan-Adam force-pushed the CTOR-644-plugin-network-moxa-switch-snmp-mode-interfaces-option-add-duplex-status-duplex-unknown branch from a97ec71 to c6eca80 Compare February 4, 2025 11:04
@Evan-Adam Evan-Adam force-pushed the CTOR-644-plugin-network-moxa-switch-snmp-mode-interfaces-option-add-duplex-status-duplex-unknown branch from c6eca80 to 41b1c18 Compare February 4, 2025 12:45
@Evan-Adam Evan-Adam marked this pull request as ready for review February 4, 2025 12:59
@Evan-Adam Evan-Adam requested review from a team as code owners February 4, 2025 12:59
@sdepassio sdepassio merged commit 0dae1d9 into develop Feb 4, 2025
30 checks passed
@sdepassio sdepassio deleted the CTOR-644-plugin-network-moxa-switch-snmp-mode-interfaces-option-add-duplex-status-duplex-unknown branch February 4, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants