Ctor 1218 plugin storage purestorage #5403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfarouq-ext
force-pushed
the
CTOR-1218-plugin-storage-purestorage
branch
from
04cbd6b to
6885521
Compare
Evan-Adam
reviewed
Feb 2, 2025
| @@ -98,7 +98,9 @@ sub manage_selection { | |||
|
|
|||
| my $last_time; | |||
| if (defined($self->{option_results}->{memory})) { | |||
| $self->{statefile_cache}->read(statefile => 'purestorage_' . $self->{mode} . '_' . $options{custom}->get_connection_infos()); | |||
| #use Data::Dumper; | |||
There was a problem hiding this comment.
Please remove this commented code or add it to debug mode of the plugin
|
|
||
| Examples: tc extra_options expected_result -- | ||
| ... 1 --filter-category='array' CRITICAL: 2 problem(s) detected | 'alerts.detected.count'=2;;;0; | ||
| ... 2 --warning-status='\\\%{state} = "warning"' CRITICAL: 2 problem(s) detected | 'alerts.detected.count'=2;;;0; |
There was a problem hiding this comment.
You change the warning condition in the option, but the plugin output critical status, so you are not checking that the warning option work with this.
Can you change the critical status too in this test so the plugin en in warning ?
It will allows to be sure the plugin can output warning if there is a matching condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#CTOR-1218
Type of change
Checklist