Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(huawei-wlc): new snmp plugin #5301

Merged
merged 33 commits into from
Dec 17, 2024
Merged

feat(huawei-wlc): new snmp plugin #5301

merged 33 commits into from
Dec 17, 2024

Conversation

omercier
Copy link
Contributor

@omercier omercier commented Nov 28, 2024 •
edited
Loading

Description

Refs: CTOR-13
CTOR-13
New pack Huawei WLC SNMP
Contribution from PR #5146
Replaces #5293

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Functionality enhancement or optimization (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched.
Provide clear instructions so that it can be correctly tested.
Mention the automated tests included in this FOR (what they test like mode/option combinations).

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).
  • In case of a new plugin, I have created the new packaging directory accordingly.
  • I have implemented automated tests related to my commits.
  • I have reviewed all the help messages in all the .pm files I have modified.
    • All sentences begin with a capital letter.
    • All sentences are terminated by a period.
    • I am able to understand all the help messages, if not, exchange with the PO or TW to rewrite them.
  • After having created the PR, I will make sure that all the tests provided in this PR have run and passed.

@omercier omercier mentioned this pull request Nov 29, 2024
Closed
14 tasks
@omercier omercier force-pushed the CTOR-13-new-pack-network-huawei-wlc-snmp-complete branch from ae94b4a to de46989 Compare December 2, 2024 12:58
@omercier omercier changed the title Ctor 13 new pack network huawei wlc snmp complete feat(huawei-wlc): new snmp plugin Dec 2, 2024
rmorandell-pgum and others added 26 commits December 10, 2024 09:23
@rmorandell-pgum @omercier
new huawei standard snmp
e455eec
@rmorandell-pgum @omercier
Delete src/network/huawei/snmp/mode directory
2715281 
moved to centreon::common::huawei::standard::snmp::mode
@rmorandell-pgum @omercier
Delete src/network/huawei/snmp/plugin.pm
7e17bd2 
centreon::common::huawei::standard::snmp
@rmorandell-pgum @omercier
network-huawei-standard-snmp-plugin
9b3883b 
network::huawei::standard::snmp::plugin
@rmorandell-pgum @omercier
new network-huawei-wlc-snmp-plugin
212ca67 
network::huawei::wlc::snmp::plugin
@rmorandell-pgum @omercier
new mode "wlan-global"
0437be5
@rmorandell-pgum @omercier
new mode "wlan-global"
8a7ad76
@rmorandell-pgum @omercier
added some counter to apstatus
fbf8204
@rmorandell-pgum @omercier
init "faults" with 0
afc4952
@pkippes @omercier
Empty-Commit
f49f38c
@tuntoja @kduret @omercier
fix(promote): fix promote behavior to handle new debian package naming (
a7d871e 
#5240)

Co-authored-by: Kevin Duret <[email protected]>
@omercier
Add data for tests
91ae850
@sfarouq-ext @omercier
new tests(network::huawei::wlc::snmp)
6ca781b
@pkippes @omercier
Empty-Commit
3925b82
@tuntoja @kduret @omercier
fix(promote): fix promote behavior to handle new debian package naming (
92b0cf9 
#5240)

Co-authored-by: Kevin Duret <[email protected]>
@omercier
fix(spelling): fixed the spellchecks issues by various means
b505b47 
- protect technical keywords with POD code brakets
- added some stopwords
- enhanced the spellcheck script to work on my local environment as well
@omercier
fix(spelling): last error
569deed
@omercier
feat(packaging): add packaging files
94881a3
@omercier
fix(memory+tests): sorted the instances to get consistent results
257fbf5
@omercier
fix(apstatus): sorted the keys to make results consistent
24084ad
@omercier
fix(tests): fixed listradios, dos2unixed some files, enhanced pod_spe…
b246e4e 
…ll_check
@omercier
fix(tests): sorted the data processing order and removed verbosity
9d8e9d4
@omercier
fix(tests): sorted the data processing order
ade1e8d
@omercier
fix(tests): sorted cpu counters + fixed reobot test
770af6d
@omercier
fix(listinterfaces): solve a warning issue + fix tests
9f0ce5c
@omercier
fix(tests): all done!
1e8331e
@omercier omercier force-pushed the CTOR-13-new-pack-network-huawei-wlc-snmp-complete branch from 729ffdb to 1e8331e Compare December 10, 2024 08:25
@omercier omercier marked this pull request as ready for review December 10, 2024 14:28
@omercier omercier requested review from a team as code owners December 10, 2024 14:28
kduret
kduret previously approved these changes Dec 11, 2024
View reviewed changes
@omercier omercier requested review from Evan-Adam and kduret December 16, 2024 10:17
@omercier omercier merged commit 3953f8d into develop Dec 17, 2024
36 checks passed
@omercier omercier deleted the CTOR-13-new-pack-network-huawei-wlc-snmp-complete branch December 17, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evan-Adam Evan-Adam Evan-Adam approved these changes

@kduret kduret kduret approved these changes

@ddes ddes Awaiting requested review from ddes ddes is a code owner automatically assigned from centreon/owners-pipelines

@jean-christophe81 jean-christophe81 Awaiting requested review from jean-christophe81 jean-christophe81 is a code owner automatically assigned from centreon/owners-robot-e2e

Assignees
No one assigned
Labels
skip-workflow-docker-builder-testing-plugins skip-workflow-plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@omercier @kduret @Evan-Adam @rmorandell-pgum @pkippes @tuntoja @sfarouq-ext