Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTOR-258-cifs,sftp,ftp plugin now check recursively folders #5015

Merged
merged 1 commit into from
May 14, 2024
Merged

CTOR-258-cifs,sftp,ftp plugin now check recursively folders #5015

merged 1 commit into from
May 14, 2024

Conversation

Evan-Adam
Copy link
Contributor

allow files-count mode to use filter-file and max-depth together.
Before this patch when filter-file was used the max-depth was always 1.

REF:CTOR-258

Description

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

See jira.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@Evan-Adam Evan-Adam requested a review from a team as a code owner May 2, 2024 13:41
@Evan-Adam Evan-Adam requested a review from sdepassio May 2, 2024 13:41
omercier
omercier reviewed May 6, 2024
View reviewed changes
src/apps/protocols/ftp/mode/filescount.pm Outdated Show resolved Hide resolved
src/apps/protocols/ftp/mode/filescount.pm Outdated Show resolved Hide resolved
src/apps/protocols/ftp/mode/filescount.pm Show resolved Hide resolved
src/apps/protocols/sftp/mode/filescount.pm Show resolved Hide resolved
omercier
omercier previously approved these changes May 6, 2024
View reviewed changes
@Evan-Adam Evan-Adam force-pushed the CTOR-258-applications-protocol-cifs-ftp-sftp-mode-files-count-filter-file-not-working-with-max-depth branch from 44ec2bd to 240f56f Compare May 7, 2024 09:43
@Evan-Adam Evan-Adam force-pushed the CTOR-258-applications-protocol-cifs-ftp-sftp-mode-files-count-filter-file-not-working-with-max-depth branch from 240f56f to dcaec37 Compare May 7, 2024 09:45
@Evan-Adam Evan-Adam merged commit 3028639 into develop May 14, 2024
16 checks passed
@Evan-Adam Evan-Adam deleted the CTOR-258-applications-protocol-cifs-ftp-sftp-mode-files-count-filter-file-not-working-with-max-depth branch May 14, 2024 08:37
omercier pushed a commit that referenced this pull request May 28, 2024
@Evan-Adam @omercier
fix(plugin) cifs,sftp,ftp plugin now check recursively folders (#5015)
6704157 
REF:CTOR-258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omercier omercier omercier approved these changes

@lucie-dubrunfaut lucie-dubrunfaut lucie-dubrunfaut approved these changes

@sdepassio sdepassio Awaiting requested review from sdepassio sdepassio is a code owner automatically assigned from centreon/owners-perl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Evan-Adam @omercier @lucie-dubrunfaut