Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTOR-258-escalation-centreon-plugin-applications-protocol-cifs-mode-files-count-filter-file-not-working-with-max-depth #5014

Closed
wants to merge 12 commits into from
Closed

CTOR-258-escalation-centreon-plugin-applications-protocol-cifs-mode-files-count-filter-file-not-working-with-max-depth #5014

wants to merge 12 commits into from

Conversation

Evan-Adam
Copy link
Contributor

Description

allow files-count mode to use filter-file and max-depth together.
Before this patch when filter-file was used the max-depth was always 1.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

How this pull request can be tested ?

See jira.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@Evan-Adam Evan-Adam changed the base branch from develop to CTOR-474-use-docker-to-test-plugin-v2 May 2, 2024 08:24
Base automatically changed from CTOR-474-use-docker-to-test-plugin-v2 to develop May 2, 2024 09:11
@Evan-Adam Evan-Adam force-pushed the CTOR-258-escalation-centreon-plugin-applications-protocol-cifs-mode-files-count-filter-file-not-working-with-max-depth branch from ac16028 to 838ff78 Compare May 2, 2024 12:33
Evan-Adam and others added 12 commits May 2, 2024 15:34
@Evan-Adam
feat(plugin/tests) add new dockerfile for testing purpose
4e9cf61 
FIX:CTOR-474
@Evan-Adam
fix packaging path wrong and fix used on it
baddb0c 
FIX:CTOR-474

historically, nfpm configuration (pkg.json) where in a directory named
after the plugin package name. some dir where wrongly named, and a fix
was made in the code to manage this case. I fixed every packages dir
name.
@Evan-Adam
New python script to install, test and remove all plugin passed as pa…
0ae29c0 
…rameter.

REF:CTOR-474
@Evan-Adam
remove useless code, comment python script and indent everything
8d19c66 
REF:CTOR-474
@Evan-Adam
remove plugins modifications
2ba838c 
REF:CTOR-474
@Evan-Adam
change after review
a9a38dc 
REF:CTOR-474
@Evan-Adam
ci(plugins-tests) Add apt/dnf logs as artifact. Change some descriptions
9f0ba71 
REF:CTOR-474
@Evan-Adam @mushroomempires
Apply suggestions from code review
4fbdbf0 
Co-authored-by: May <[email protected]>
@Evan-Adam
add back snmpsim run in tests
bd1b133 
REF:CTOR-474
@Evan-Adam
remove uselless workdir docker call
1be14de 
REF:CTOR-474
@Evan-Adam
Let npm take the last mockoon version
1b6b16d 
REF:CTOR-474
@Evan-Adam
fix(plugins) cifs,sftp,ftp plugin now check recursively folders when …
7269196 
…filter-file parameter is used.

REF:CTOR-258
@Evan-Adam Evan-Adam force-pushed the CTOR-258-escalation-centreon-plugin-applications-protocol-cifs-mode-files-count-filter-file-not-working-with-max-depth branch from 838ff78 to 7269196 Compare May 2, 2024 13:34
@Evan-Adam Evan-Adam closed this May 2, 2024
@Evan-Adam Evan-Adam deleted the CTOR-258-escalation-centreon-plugin-applications-protocol-cifs-mode-files-count-filter-file-not-working-with-max-depth branch May 2, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Evan-Adam