-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single quote in change-perfdata help #4803
Merged
Evan-Adam
merged 2 commits into
develop
from
CTOR-71-change-perfdata-traffic-in-scale-mbps-mbps-does-not-work-as-documented
Jan 31, 2024
Merged
Add single quote in change-perfdata help #4803
Evan-Adam
merged 2 commits into
develop
from
CTOR-71-change-perfdata-traffic-in-scale-mbps-mbps-does-not-work-as-documented
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omercier
previously approved these changes
Jan 8, 2024
lucie-dubrunfaut
approved these changes
Jan 9, 2024
sc979
reviewed
Jan 11, 2024
sc979
reviewed
Jan 11, 2024
sc979
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @YanMeddour ,
Kindly, could you rebase your branch on develop ?
git rebase origin/develop
Some commits have already been merged and should not be displayed 🤔
665efa3
to
7114884
Compare
lucie-dubrunfaut
previously approved these changes
Jan 30, 2024
omercier
reviewed
Jan 30, 2024
sdepassio
approved these changes
Jan 30, 2024
sc979
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID (for centreon-internal)
Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist
Community contributors & Centreon team