Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single quote in change-perfdata help #4803

Conversation

YanMeddour
Copy link
Contributor

@YanMeddour YanMeddour commented Jan 4, 2024

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID (for centreon-internal)

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@YanMeddour YanMeddour requested a review from omercier January 4, 2024 13:35
@YanMeddour YanMeddour requested a review from a team as a code owner January 4, 2024 13:35
omercier
omercier previously approved these changes Jan 8, 2024
@YanMeddour YanMeddour requested review from a team as code owners January 11, 2024 14:13
Copy link
Contributor

@sc979 sc979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @YanMeddour ,

Kindly, could you rebase your branch on develop ?
git rebase origin/develop
Some commits have already been merged and should not be displayed 🤔

@sdepassio sdepassio force-pushed the CTOR-71-change-perfdata-traffic-in-scale-mbps-mbps-does-not-work-as-documented branch from 665efa3 to 7114884 Compare January 29, 2024 10:45
@Evan-Adam Evan-Adam merged commit 5a67220 into develop Jan 31, 2024
10 checks passed
@Evan-Adam Evan-Adam deleted the CTOR-71-change-perfdata-traffic-in-scale-mbps-mbps-does-not-work-as-documented branch January 31, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants