Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CTOR-46] [Plugin] Add Pack Teldat SNMP #4758

Closed
wants to merge 37 commits into from

Conversation

lucie-dubrunfaut
Copy link
Contributor

Description

Add Teldat SNMP plugin with following modes :

  • CPU
  • Mémoire
  • Traffic
  • Hardware
  • Cells-Radio

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (develop).

};
}

if (scalar(keys %{$self->{cells}}) <= 0 && defined($self->{option_results}->{filter_cell_id}) && $self->{option_results}->{filter_cell_id} ne '') {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omercier Avoid OK: Empty output if the filter didn't catch anything (see below). But maybe in link with the overall issue with OK: Empty outputs.

# Return : OK:  | 'modules.cellradio.detected.count'=0;;;0;
    # return if (scalar(keys %{$self->{cells}}) <= 0);

@lucie-dubrunfaut lucie-dubrunfaut marked this pull request as ready for review January 8, 2024 16:36
@lucie-dubrunfaut lucie-dubrunfaut requested review from a team as code owners January 8, 2024 16:36
@lucie-dubrunfaut lucie-dubrunfaut deleted the MON-20130-teldat-snmp branch January 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants