Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(chore): new code_owners #4748

Closed
wants to merge 1 commit into from
Closed

enh(chore): new code_owners #4748

wants to merge 1 commit into from

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Nov 23, 2023

Description

Add code owners fils

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

@sc979 sc979 requested review from bouda1, bdauria, kduret, tuntoja and a team November 23, 2023 10:51
kduret
kduret reviewed Nov 23, 2023
View reviewed changes
Copy link
Contributor

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should target develop branch

@sc979
Copy link
Contributor Author

sc979 commented Nov 23, 2023 •
edited
Loading

you should target develop branch

Develop's PR is here : #4747
Should I close this one ?

@kduret
Copy link
Contributor

kduret commented Nov 23, 2023

you should target develop branch

Develop's PR is here : #4747 Should I close this one ?

yes please :)

@sc979 sc979 closed this Nov 23, 2023
@sc979 sc979 deleted the MON-21430-code-owners-on-master branch November 23, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kduret kduret kduret left review comments

@bouda1 bouda1 Awaiting requested review from bouda1

@bdauria bdauria Awaiting requested review from bdauria

@tuntoja tuntoja Awaiting requested review from tuntoja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc979 @kduret