This repository was archived by the owner on Dec 13, 2022. It is now read-only.
Issue 11673: unify parseShowParameters between CentreonRtDowntime and CentreonRtAcknowledgement #12049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy parameters handling in parseShowParameters from centreonRtAcknowledgement to remove WARNING of Undefined array key 1
Unifiy parseShowParameters between centreonRtAcknowledgement and centreonRtDowntime. Use return array()
|
SonarQube Quality Gate
|
|
migrated to https://github.com/centreon/centreon-gha/pull/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR unifies parseShowParameters between CentreonRtDowntime and CentreonRtAcknowledgement classes für CLAPI to get rid of the following message:
From CentreonRtAcknowledgement we use the more sophisticated handling to parse parameters into type and ressouce
From CentreonRtDowntime we use the style to generate the return value
Partially Fixes #11673
Type of change
Target serie
How this pull request can be tested ?
Use CLAPI to add and remove Host and Service-Downtimes
Checklist
Community contributors & Centreon team
The PR is based on the develop branch because that seems is the current default branch.