Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANIFEST.in: Add LICENSE, docs, contrib and tests #804

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 15, 2019

No description provided.

@jayvdb jayvdb requested review from c24t, reyang, songy23 and a team as code owners October 15, 2019 04:00
@reyang
Copy link
Contributor

reyang commented Oct 15, 2019

Do we need source distribution at all or we should just remove this file?

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 16, 2019

As a packager, I find it very helpful for repos with multiple packages to have good sdists. The core requirement is to be able to get a versioned tarball that includes tests. At the moment, the only option here is to fetch the tarball for the repo release on GitHub.

The google cloud python repo is a great example to follow.

I have started packaging these.
As you can see at https://build.opensuse.org/package/show/home:jayvdb:py-new/python-opencensus-context , not having a package sdist with tests means the package needs to fetch the very big tarball, and logic of the .spec is a bit odd.

https://build.opensuse.org/package/show/home:jayvdb:py-new/python-opencensus is also more complicated than it needs to be, but that is also because the extensions are needed for the main test suite.

Copy link
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants