Remove unused json formatters #651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c24t
force-pushed
the
remove-unused-json-formatters
branch
from
51aebf6 to
0a7c72c
Compare
Merged
|
This PR has grown in scope a bit as I've tried to quarantine stackdriver logic in the stackdriver exporter. See #649 (comment) for details. |
c24t
force-pushed
the
remove-unused-json-formatters
branch
3 times, most recently
from
4dd4858 to
ab9e4a6
Compare
songy23
reviewed
May 15, 2019
c24t
force-pushed
the
remove-unused-json-formatters
branch
from
ab9e4a6 to
5b81677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #649 (comment) to remove
span.format_span_json. I'll rebase this PR once #649 is merged.