Store fake Tracer when parent_span is None #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the code checks if parent_span is None only after it's stored. Either the checks runs when it's too late or it's not needed in the first place. Assume the former.
|
Uh, this breaks TestSpan.test_constructor_defaults. So perhaps the code serves no purpose? @liyanhui1228, you added the code in therc@a155f47, is it a bad copy and paste from context_tracer.py? |
|
Ping? |
therc
requested review from
aabmass,
hectorhdzg,
lzchen,
songy23 and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the code checks if parent_span is None only after it's stored.
Either the checks runs when it's too late or it's not needed in the first place. Assume the former.