Conversation
Previously the cost estimator log would be moved to a ...-failure.log or ...success.log after printting the log when cleaning up the process, this meant that the logged log no longer existed.
The previous hardcoded value of 3 was causing the monitor to get overloaded, so made it configurable and set the default to 1.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2602e7903
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9363ace490
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| max_history_length, | ||
| max_retries, | ||
| history_file, | ||
| sequence_tracker: SequenceTracker::new(next_game_index), |
There was a problem hiding this comment.
MonitorState::new seeds SequenceTracker with next_game_index, but next_game_index is the next item to process (e.g. progress.last_contiguous + 1), not the last contiguous completion. That makes the first processed game after startup look like an already-accounted index, so mark_game_completed does not advance and save_progress is skipped. In practice, if only one new game is processed before a restart, the monitor resumes from the same index and re-runs that game again, defeating the new persisted progress behavior.
Useful? React with 👍 / 👎.
1 participant
Relates to https://github.com/celo-org/celo-blockchain-planning/issues/1275