fix: correct L2 claim block timestamp calculation in BPO disabling logic#140
Merged
fix: correct L2 claim block timestamp calculation in BPO disabling logic#140
Conversation
The blob params for osaka and BPO hardforks are currently stripped based on the claimed l2 block timestamp, comparing if it's Jovian activated or not. For Celo Mainnet, the genesis l2_time is not the timestamp for the 0th block, so we have to subtract the genesis l2 block number from the claimed l2 block number to get the correct timestamp.
seolaoh
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6ec8765cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
3 tasks
palango
approved these changes
Mar 16, 2026
Contributor
palango
left a comment
palango
left a comment
There was a problem hiding this comment.
Interesting edge cases we run int ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jovian_timeto celo-registry configsCeloBootInfo::load()computesl2_claim_block_timestampasgenesis.l2_time + l2_claim_block * block_time, but Celo Mainnet's genesis L2 block number is 31,056,500 (not 0), so the calculation must subtract the genesis block number:genesis.l2_time + (l2_claim_block - genesis.l2.number) * block_timeis_jovian_active()return true for pre-Jovian blocks. This skips the osaka/BPO stripping, causing the wrongblob_base_feeto be calculated using BPO2 blob params instead of the expected paramsNote
This only affects Celo Mainnet, as Celo Sepolia and Celo Chaos have genesis L2 block number 0.