Skip to content

fix(tag-db): import fs so SG tag database uploads persist #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
meelyn-pandit wants to merge 2 commits into
base: lts_24-06.iso
Choose a base branch
from
Open

fix(tag-db): import fs so SG tag database uploads persist #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3021d1c
fix(tag-db): import fs so SG tag database uploads persist
meelyn-pandit Jul 20, 2026
4e52ec4
fix(tag-db): rm -f so first-time tag DB upload (no existing file) works
meelyn-pandit Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/station-interface/routes/sensorgnome/upload-sg-tag-file.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import fs from 'fs'

import RunCommand from '../../../command.js'

const BASE_SG_TAG_DB_NAME = 'SG_tag_database'
Expand All @@ -7,7 +9,10 @@ export default (req, res, next) => {
const ext = req.get('file-extension')
const filename = `${BASE_SG_TAG_DB_NAME}.${ext}`
console.log('about to delete sg tag db files')
RunCommand(`rm /data/sg_files/${BASE_SG_TAG_DB_NAME}*`)
// Use rm -f: on a station with no existing tag DB the glob matches nothing,
// and a plain rm exits non-zero, rejecting the promise before the write ever
// runs. -f treats "nothing to remove" as success.
RunCommand(`rm -f /data/sg_files/${BASE_SG_TAG_DB_NAME}*`)
.then(() => {
let uri = `/data/sg_files/${filename}`
console.log('writing tag database file')
Expand Down