chore: use embed pkg to split long template to file
#1412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winniehere
requested review from
ramin and
evan-forbes
and removed request for
a team
winniehere
force-pushed
the
refactor/embed-tpl
branch
from
885d484 to
5281171
Compare
|
@rootulp Hi sir, anything else that need I update for this pr? |
|
How was this PR tested? Did you run the e2e test before + after this change to confirm that the template works as expected? Can you please document testing in the PR description. |
winniehere
force-pushed
the
refactor/embed-tpl
branch
from
7e3ebfd to
ceb5e80
Compare
|
thanks for this @winniehere, I would change this upstream in CometBFT first, and then we could pull after |
Hi sir @evan-forbes , I didn't see the changed files in the upstream repo, I thought they are new custom files in this repo, did I miss something here? |
|
I don't think so, we haven't changed the e2e that much we are unlikely to pull this in unless its included upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting long content template into file is more friendly for reading, also for IDE rendering.
BTW: I noticed that
config/toml.gohas introduced the similar changes in upstreamcometbft/comebft, so I didn't update it.