Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Mantine to Version 7 #599

Open
otobot1 opened this issue Oct 6, 2023 · 5 comments
Open

Migrate Mantine to Version 7 #599

otobot1 opened this issue Oct 6, 2023 · 5 comments
Labels
priority: low status: wait Cannot address at this time type: dependencies Pull requests that update a dependency file
Milestone

Comments

@otobot1
Copy link
Member

otobot1 commented Oct 6, 2023

Is your feature request related to a problem? Please describe.
A new major version of Mantine has been released.

Describe the solution you'd like
There are a lot of breaking changes, but the sooner we update the less code we will need to rewrite. The biggest changes are the removal of the createStyles hook in favour of CSS modules, as well as some other styling changes. We will need to simultaneously update our code, all Mantine packages, and MantineDataTable.

Describe alternatives you've considered
N/A. This is required, but it can be pushed to a later milestone if needed.

Additional context
MantineDataTable will need to be updated at the same time, but may take a few weeks to be updated as per this comment. MantineDataTable v7 has been released.

@otobot1 otobot1 added status: help wanted This issue is low-priority for maintainers. Any user is welcome to submit a pull request type: dependencies Pull requests that update a dependency file priority: high labels Oct 6, 2023
@otobot1 otobot1 added this to the v0.2.0 milestone Oct 6, 2023
@otobot1 otobot1 changed the title Migrate to Mantine Version 7 Migrate Mantine to Version 7 Oct 6, 2023
@grahampcharles
Copy link

Do you have a development branch? Or how do you want help to be provided?

@ShouvikGhosh2048
Copy link
Collaborator

@grahampcharles

Hi, I'm a contributor to this repository. I contribute by making a pull request to the main branch.

@otobot1
Copy link
Member Author

otobot1 commented Oct 8, 2023

@grahampcharles

Hey there! Yeah like Shouvik said, just fork the project and create a branch off of main. Our contribution guidelines go into a bit more detail, and our readme has instructions for setting up your local dev environment.

@grahampcharles
Copy link

I mean, that makes sense for feature adds or bugfixes. But if you want help implementing a complete rewrite in order to support Mantine 7 seems like we would want a shared branch. Someone sets the target versioning in package.json and then we divide up the work? Having just done a Mantine 6->7 conversion, it's a lot of manually creating .module.css files and replacing createStyles calls. But I don't know the internals of this package well; maybe I'm missing something.

@otobot1
Copy link
Member Author

otobot1 commented Oct 12, 2023

I mean, that makes sense for feature adds or bugfixes. But if you want help implementing a complete rewrite in order to support Mantine 7 seems like we would want a shared branch. Someone sets the target versioning in package.json and then we divide up the work? Having just done a Mantine 6->7 conversion, it's a lot of manually creating .module.css files and replacing createStyles calls. But I don't know the internals of this package well; maybe I'm missing something.

Ah yeah that makes sense - I'm still pretty new to being a maintainer. I'll try and get that setup this weekend, but a lot of our styling isn't on main yet anyways (see #563). At the moment we're pretty focused on meeting our v0.1.0 milestone and getting the site launched, so Shouvik and I probably won't be touching this issue for a month or two.

@otobot1 otobot1 added status: wait Cannot address at this time and removed status: help wanted This issue is low-priority for maintainers. Any user is welcome to submit a pull request labels Jan 29, 2024
@otobot1 otobot1 modified the milestones: v0.2.0, v0.4.0 Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low status: wait Cannot address at this time type: dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants