Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Pagination Dropdown Styles Into CSS Module #738

Open
otobot1 opened this issue Feb 25, 2024 · 0 comments
Open

Extract Pagination Dropdown Styles Into CSS Module #738

otobot1 opened this issue Feb 25, 2024 · 0 comments
Labels
Milestone

Comments

@otobot1
Copy link
Member

otobot1 commented Feb 25, 2024

Is your feature request related to a problem? Please describe.
As covered in this discussion thread, the pagination dropdown menu is being styled through global styles being applied to the body element. It would be better we used a CSS Module instead of global styles.

Describe the solution you'd like
Extract the styles into a CSS Module.

Describe alternatives you've considered
Could also address this in a similar way to item 3.ii. in this comment. It is likely that similar issues will pop up, so this approach likely won't be simple. It may be better to start using the Mantine Theme object more widely, maybe as part of migrating to Mantine v7 (#599).

Additional context
Follow-up to #723.

@otobot1 otobot1 added type: enhancement New feature or request priority: low labels Feb 25, 2024
@otobot1 otobot1 added this to the v0.4.0 milestone Feb 25, 2024
@otobot1 otobot1 changed the title Extract Pagination Dropdown Styling Into CSS Module Extract Pagination Dropdown Styles Into CSS Module Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant