Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): Make SerializationException implement BadRequestException #32

Merged
merged 1 commit into from
Feb 8, 2024
Merged

chore(core): Make SerializationException implement BadRequestException #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/celest_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## 0.2.0-dev

- Make `SerializationException` implement `BadRequestException`

## 0.1.1

- Update README
Expand Down
2 changes: 1 addition & 1 deletion packages/celest_core/lib/src/exception/cloud_exception.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ sealed class CloudException implements CelestException {}
/// An exception thrown by a Cloud Function when a request contains invalid
/// data or otherwise lead to a recoverable exception.
/// {@endtemplate}
final class BadRequestException implements CloudException {
class BadRequestException implements CloudException {
/// Creates a [BadRequestException] with the given [message].
///
/// {@macro celest_core_exception_bad_request_exception}
Expand Down
2 changes: 1 addition & 1 deletion packages/celest_core/lib/src/exception/serialization_exception.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import 'package:celest_core/celest_core.dart';
/// deserialize a value.
/// {@endtemplate}
final class SerializationException extends FormatException
implements CelestException {
implements BadRequestException, CelestException {
/// Creates a [SerializationException] with the given [message].
///
/// {@macro celest_core_exceptions_serialization_exception}
Expand Down