Do not treat Celest types specially

celest-dev · Feb 20, 2024 · 30bcbe6 · 30bcbe6
1 parent 9dc8a1a
commit 30bcbe6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 60 deletions.
diff --git a/packages/celest/lib/src/runtime/serve.dart b/packages/celest/lib/src/runtime/serve.dart
@@ -121,18 +121,6 @@ Handler _cloudExceptionMiddleware(Handler inner) {
   return (request) async {
     try {
       return await inner(request);
-    } on BadRequestException catch (e) {
-      print('Bad request: ${e.message}');
-      return _badRequest(
-        code: 'BadRequestException',
-        details: Serializers.instance.serialize(e),
-      );
-    } on InternalServerException catch (e) {
-      print('Internal server error: ${e.message}');
-      return _internalServerError(
-        code: 'InternalServerException',
-        details: Serializers.instance.serialize(e),
-      );
     } on Exception catch (e, st) {
       print('An unexpected error occurred: $e');
       print(st);

diff --git a/packages/celest_core/lib/src/exception/serialization_exception.dart b/packages/celest_core/lib/src/exception/serialization_exception.dart
@@ -13,6 +13,11 @@ final class SerializationException extends FormatException
   /// {@macro celest_core_exceptions_serialization_exception}
   const SerializationException(super.message);
 
+  @override
+  // TODO(dnys1): Find a better resolution to this.
+  // ignore: overridden_fields
+  final Null source = null;
+
   @override
   String toString() => 'SerializationException: $message';
 }
diff --git a/packages/celest_core/lib/src/serialization/serializer.dart b/packages/celest_core/lib/src/serialization/serializer.dart
@@ -3,7 +3,6 @@ import 'dart:typed_data';
 
 import 'package:celest_core/celest_core.dart';
 import 'package:celest_core/src/serialization/serializers/big_int_serializer.dart';
-import 'package:celest_core/src/serialization/serializers/cloud_exception_serializer.dart';
 import 'package:celest_core/src/serialization/serializers/date_time_serializer.dart';
 import 'package:celest_core/src/serialization/serializers/duration_serializer.dart';
 import 'package:celest_core/src/serialization/serializers/regexp_serializer.dart';
@@ -101,8 +100,6 @@ final class _Serializers extends Serializers {
     put<Uri>(const UriSerializer());
     put<UriData>(const UriDataSerializer());
     put<Uint8List>(const Uint8ListSerializer());
-    put<BadRequestException>(const BadRequestExceptionSerializer());
-    put<InternalServerException>(const InternalServerExceptionSerializer());
   }
 
   final _serializersByType = <TypeToken<Object?>, Serializer>{};

diff --git a/packages/celest_core/lib/src/serialization/serializers/cloud_exception_serializer.dart b/packages/celest_core/lib/src/serialization/serializers/cloud_exception_serializer.dart