fix(native_storage): Clearing of secure storage on macOS/iOS

The `kSecMatchLimit` flag must always be `kSecMatchLimitAll` to return a list, but this was previously not set in release mode.
celest-dev · Apr 9, 2024 · 1a48380 · 1a48380
1 parent cb0eed0
commit 1a48380
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/native_storage.yaml b/.github/workflows/native_storage.yaml
@@ -123,8 +123,6 @@ jobs:
           export DISPLAY=:99
           sudo Xvfb -ac :99 -screen 0 1280x1024x24 > /dev/null 2>&1 &
           flutter test -d linux integration_test/storage_test.dart
-  # TODO: Re-enable
-  #       Need to fix this: Git error. Command: `git clone --mirror https://github.com/dart-lang/native /c/Users/runneradmin/.pub-cache\git\cache\native-647c69ed8027da6d6def6bc40efa87cf1a2f76aa`
   test_windows:
     runs-on: windows-latest
     timeout-minutes: 15
@@ -138,9 +136,9 @@ jobs:
       - name: Get Packages
         working-directory: packages/native/storage
         run: dart pub get --no-example
-      # - name: Test
-      #   working-directory: packages/native/storage
-      #   run: dart test
+      - name: Test
+        working-directory: packages/native/storage
+        run: dart test
       - name: Get Packages (Example)
         working-directory: packages/native/storage/example
         run: flutter pub get

diff --git a/packages/native/storage/lib/src/local/local_storage.windows.dart b/packages/native/storage/lib/src/local/local_storage.windows.dart
@@ -2,7 +2,8 @@ import 'package:native_storage/src/local/local_storage_platform.vm.dart';
 import 'package:native_storage/src/native/windows/windows.dart';
 import 'package:win32_registry/win32_registry.dart';
 
-final class LocalStorageWindows extends NativeLocalStoragePlatform with NativeStorageWindows {
+final class LocalStorageWindows extends NativeLocalStoragePlatform
+    with NativeStorageWindows {
   LocalStorageWindows({
     String? namespace,
     super.scope,

diff --git a/packages/native/storage/lib/src/secure/secure_storage.windows.dart b/packages/native/storage/lib/src/secure/secure_storage.windows.dart
@@ -9,7 +9,8 @@ import 'package:native_storage/src/secure/secure_storage_platform.vm.dart';
 import 'package:win32/win32.dart';
 import 'package:win32_registry/win32_registry.dart';
 
-final class SecureStorageWindows extends NativeSecureStoragePlatform with NativeStorageWindows {
+final class SecureStorageWindows extends NativeSecureStoragePlatform
+    with NativeStorageWindows {
   SecureStorageWindows({
     String? namespace,
     super.scope,