Hotfix: pycurl again #2284
Hotfix: pycurl again #2284
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2284 +/- ##
==========================================
- Coverage 81.55% 81.06% -0.49%
==========================================
Files 77 77
Lines 9541 9628 +87
Branches 1162 1179 +17
==========================================
+ Hits 7781 7805 +24
- Misses 1568 1621 +53
- Partials 192 202 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I can also port certifi ssl certificate finding mechanism to pycurl implementation if desired |
|
@auvipy explain "clean revert" |
spawn-guy
force-pushed
the
hotfix_pycurl
branch
from
5cd0260 to
1e8ee2f
Compare
|
@auvipy i've been thinking about your request. and i got to a conclusion. i see no point in doing exactly that. only for the sake of "commit history". so, in the end |
|
before merging this, we should also consider #2300 |
kombu/asynchronous/http/curl.py
Outdated
| @@ -252,14 +252,19 @@ def _setup_request(self, curl, request, buffer, headers, _pycurl=pycurl): | |||
| setopt(meth, True) | |||
|
|
|||
| if request.method in ('POST', 'PUT'): | |||
| body = request.body.encode('utf-8') if request.body else b'' | |||
There was a problem hiding this comment.
you can rebase this so that we can merge this change
There was a problem hiding this comment.
Id close this one completely and go with the other one with Urllib3.
Shall I?
There was a problem hiding this comment.
that could be an option, but may be just extracting the pycurl related improvement would make it usable and the urllib3 vr PR easier to review :)
as discussed in #2258
urllib3http client(as not ready for production)pycurlas hardsqsdependencyrequest.bodybytesconversion (as in current code)