jira-translator-cdevents : translate jira issue and worklog events into ticket CDEvents #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 25, 2024 14:38
Signed-off-by: Jalander Ramagiri <[email protected]>
Signed-off-by: Jalander Ramagiri <[email protected]>
Signed-off-by: Jalander Ramagiri <[email protected]>
Signed-off-by: Jalander Ramagiri <[email protected]>
xibz
requested changes
Aug 29, 2024
Comment on lines
+31
to
+32
| pEvent = &JiraEvent{event} | ||
| return |
There was a problem hiding this comment.
Suggested change
| pEvent = &JiraEvent{event} | |
| return | |
| return &JiraEvent{event} |
| Event string | ||
| } | ||
|
|
||
| func NewJiraEvent(event string) (pEvent *JiraEvent) { |
There was a problem hiding this comment.
Suggested change
| func NewJiraEvent(event string) (pEvent *JiraEvent) { | |
| func NewJiraEvent(event string) *JiraEvent { |
| "net/http" | ||
| ) | ||
|
|
||
| type JiraEvent struct { |
There was a problem hiding this comment.
If it is only a single string field, we can do something like this instead
type JiraEvent string
xibz
requested changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes for a plugin implementation of
EventTranslatorinterface that is exposed by CDEvents Webhook Adapter to translate jira events into CDEvents.Below are the Jira events that are currently have mappings with CDEvents and are supported by this translator.
Note:
webhook-adapterdependency also will be updated once sdk-go v0.4 releasedSigned-off-by: Jalander Ramagiri @rjalander